Fix Espresso.onIdle for non-main Loopers on Baklava. #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
piper_713791142
branch
from
2cadab7 to
23da7bf
Compare
LooperIdlingResourceInterrogationHandler, which is used for non main Loopers, requires calling peekAtQueueState from the main Looper thread. The previous Interrogator implementation, when used on Baklava, didn't effectively support this because TestLooperManager.acquire needs to be called from the Looper's thread. This commit refactors Interrogator so it be acquired and stored on the Looper's current thread. PiperOrigin-RevId: 714149090
copybara-service
bot
force-pushed
the
piper_713791142
branch
from
23da7bf to
8091cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Espresso.onIdle for non-main Loopers on Baklava.
LooperIdlingResourceInterrogationHandler, which is used for non main Loopers,
requires calling peekAtQueueState from the main Looper thread. The previous Interrogator implementation,
when used on Baklava, didn't effectively support this because TestLooperManager.acquire
needs to be called from the Looper's thread.
This commit refactors Interrogator so it be acquired and stored on the Looper's current thread.